Hi,
On Mon, Oct 3, 2022 at 2:10 AM Andres Freund <andres@anarazel.de> wrote:
> On 2022-09-07 18:23:06 +0900, Amit Langote wrote:
> > Attached updated patches.
>
> Thanks to Justin's recent patch (89d16b63527) to add
> -DRELCACHE_FORCE_RELEASE -DCOPY_PARSE_PLAN_TREES -DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST
> to the FreeBSD ci task we now see the following:
>
> https://cirrus-ci.com/task/4772259058417664
> https://api.cirrus-ci.com/v1/artifact/task/4772259058417664/testrun/build/testrun/main/regress/regression.diffs
>
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/updatable_views.out
/tmp/cirrus-ci-build/build/testrun/main/regress/results/updatable_views.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/updatable_views.out 2022-10-02 10:37:08.888945000 +0000
> +++ /tmp/cirrus-ci-build/build/testrun/main/regress/results/updatable_views.out 2022-10-02 10:40:26.947887000 +0000
> @@ -1727,14 +1727,16 @@
> (4 rows)
>
> UPDATE base_tbl SET id = 2000 WHERE id = 2;
> +WARNING: outfuncs/readfuncs failed to produce an equal rewritten parse tree
> UPDATE rw_view1 SET id = 3000 WHERE id = 3;
> +WARNING: outfuncs/readfuncs failed to produce an equal rewritten parse tree
> SELECT * FROM base_tbl;
> id | idplus1
> ------+---------
> 1 | 2
> 4 | 5
> - 2000 | 2001
> - 3000 | 3001
> + 2000 | 3
> + 3000 | 4
> (4 rows)
>
> DROP TABLE base_tbl CASCADE;
>
> and many more.
Thanks for the heads up. Grateful for those new -D flags.
Turns out I had forgotten to update out/readRangeTblEntry() after
bringing extraUpdatedCols back into RangeTblEntry per Tom's comment.
Fixed in the attached.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
