Re: makeAndExpr(), etc. confined to gram.y? - Mailing list pgsql-hackers

From Amit Langote
Subject Re: makeAndExpr(), etc. confined to gram.y?
Date
Msg-id CA+HiwqHn9OHCksuOq6AC5iKGsXpQSLvjMMxuOUFmmGCRhkhHOA@mail.gmail.com
Whole thread Raw
In response to Re: makeAndExpr(), etc. confined to gram.y?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: makeAndExpr(), etc. confined to gram.y?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jun 25, 2014 at 1:27 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
>> Is there a reason why they've been left out of
>> makefuncs.h/makefuncs.c? Perhaps they are not supposed to be used
>> outside gram.y at all? For example, previously a caller (potentially)
>> outside parser could do a makeA_Expr(AEXPR_AND, ...). I guess this is
>> no longer possible with AEXPR_AND gone?
>
> What would be the purpose?  There is noplace except gram.y that builds
> raw parse trees.
>

Yeah, that is true. Sorry, I am unaware as to how generic make*
functions in gram.y are and how they differ from those in makefuncs.c.

So, use of make* family of functions outside parser is their abuse in
some way? Anything that needs to use these functions should somehow be
accomplished in parser perhaps. For example, duplicate/redundant CHECK
expressions elimination and such?

--
Amit



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Cluster name in ps output
Next
From: Fujii Masao
Date:
Subject: Re: pg_receivexlog add synchronous mode