Re: Forget close an open relation in ReorderBufferProcessTXN() - Mailing list pgsql-hackers

From Amit Langote
Subject Re: Forget close an open relation in ReorderBufferProcessTXN()
Date
Msg-id CA+HiwqHLKrZ4XcZ7kpwwQSM4L2Lwg_0T2O6-D=r+T195a8oNLA@mail.gmail.com
Whole thread Raw
In response to Re: Forget close an open relation in ReorderBufferProcessTXN()  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, Jun 1, 2021 at 6:56 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Mon, May 31, 2021 at 8:51 AM Amit Langote <amitlangote09@gmail.com> wrote:
> > On Thu, May 27, 2021 at 3:36 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > Why do we need to move send_relation_and_attrs() call? I think it
> > > doesn't matter much either way but OTOH, in the existing code, if
> > > there is an error (say 'out of memory' or some other) while building
> > > the map, we won't send relation attrs whereas with your change we will
> > > unnecessarily send those in such a case.
> >
> > That's a good point.  I've reverted that change in the attached.
>
> Pushed.

Thank you.

-- 
Amit Langote
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: parent foreign tables and row marks
Next
From: Robert Haas
Date:
Subject: Re: storing an explicit nonce