On Tue, Jan 18, 2022 at 12:42 AM Zhihong Yu <zyu@yugabyte.com> wrote:
> Hi,
> For patch 02, in the description:
Thanks for looking.
> present for locking views during execition
>
> Typo: execution.
>
> + * to be used by the executor to lock the view relation and for the
> + * planner to be able to record the view relation OID in the PlannedStmt
> + * that it produces for the query.
>
> I think the sentence about executor can be placed after the sentence for the planner.
Fixed.
> For patch 01, GetRelPermissionInfo():
>
> + return perminfo;
> + }
> + else
>
> keyword 'else' is not needed - the else block can be left-indented.
OK, done.
Also needed fixes when rebasing.
--
Amit Langote
EDB: http://www.enterprisedb.com