Re: pgsql: Add isolation tests for snapshot behavior in ri_triggers.c - Mailing list pgsql-committers

From Amit Langote
Subject Re: pgsql: Add isolation tests for snapshot behavior in ri_triggers.c
Date
Msg-id CA+HiwqGwws0xNvW6CMC6F5haeOxFnvntDhTEZjQst24Z7irKXw@mail.gmail.com
Whole thread Raw
In response to pgsql: Add isolation tests for snapshot behavior in ri_triggers.c  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-committers
Hi Alvaro,

On Fri, Apr 8, 2022 at 3:32 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Add isolation tests for snapshot behavior in ri_triggers.c
>
> They are to check the behavior of RI_FKey_check() and
> ri_Check_Pk_Match().  A test case whereby RI_FKey_check() queries a
> partitioned PK table under REPEATABLE READ isolation produces wrong
> output due to a bug of the partition-descriptor logic and that is noted
> as such in the comment in the test.  A subsequent commit will fix the
> bug and replace the buggy output by the correct one.

Should this one also have been reverted?  I wonder if it might be
better to add this suite with the (yet unwritten) patch to fix the bug
mentioned in the above commit message, which will likely be
back-ported.

-- 
Amit Langote
EDB: http://www.enterprisedb.com



pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Put new command-line options into alphabetical order in help out
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix the dates of some copyright notices