Re: pgsql: Allow generalized expression syntax for partition bounds - Mailing list pgsql-committers

From Amit Langote
Subject Re: pgsql: Allow generalized expression syntax for partition bounds
Date
Msg-id CA+HiwqGPEzudQ6Y6nXyCOQbLk31S3EkSJMC9SH25nJtYwUwChA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Allow generalized expression syntax for partition bounds  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Allow generalized expression syntax for partition bounds
List pgsql-committers
On Sat, Jan 26, 2019 at 11:05 Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Jan 25, 2019 at 10:37:22AM +0000, Peter Eisentraut wrote:
> Allow generalized expression syntax for partition bounds
>
> Previously, only literals were allowed.  This change allows general
> expressions, including functions calls, which are evaluated at the
> time the DDL command is executed.
>
> Besides offering some more functionality, it simplifies the parser
> structures and removes some inconsistencies in how the literals were
> handled.

fulmar, magpie and treepie are unhappy after this commit, and all of
them have the same complaint related to the order consistency of
partitions showing up in psql:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=magpie&dt=2019-01-25%2011%3A04%3A07

    Partition key: LIST (a)
-Partitions: part_1 FOR VALUES IN (1),
+Partitions: part_null FOR VALUES IN (NULL),
+            part_1 FOR VALUES IN (1),
             part_2 FOR VALUES IN (2),
-            part_3 FOR VALUES IN (3),
-            part_null FOR VALUES IN (NULL)
+            part_3 FOR VALUES IN (3)

Have sent the patch on the -hackers thread for this patch after Tom pointed out one of these failures.

Thanks,
Amit

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Allow UNLISTEN in hot-standby mode.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Allow generalized expression syntax for partition bounds