Re: BEFORE UPDATE trigger on postgres_fdw table not work - Mailing list pgsql-hackers

From Amit Langote
Subject Re: BEFORE UPDATE trigger on postgres_fdw table not work
Date
Msg-id CA+HiwqG0RpHo5wV+owGX9WCONE81EpOtJWzaPcvMiaYwPmZPBA@mail.gmail.com
Whole thread Raw
In response to Re: BEFORE UPDATE trigger on postgres_fdw table not work  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: BEFORE UPDATE trigger on postgres_fdw table not work
List pgsql-hackers
Fujita-san,

On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> I did that, but couldn't find any issue about the patch.  Here is an
> updated version of the patch.

Thanks for the updating the patch.

>  Changes are:
>
> * Reworded the comments a bit in postgresPlanFoereignModify the
> original patch modified

+     * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
+     * triggers might change values for non-target columns, in which case we

First line seems to be missing a word or two.  Maybe:

+     * statement, and for UPDATE if there are BEFORE ROW UPDATE triggers,
+     * since those triggers might change values for non-target columns, in

Thanks,
Amit



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pgbench rate limiting changes transaction latency computation
Next
From: legrand legrand
Date:
Subject: Re: Adaptive query optimization