Re: doc phrase: "inheritance child" - Mailing list pgsql-hackers

From Amit Langote
Subject Re: doc phrase: "inheritance child"
Date
Msg-id CA+HiwqFaDCNDimk=ibRY-AHccr5TmwOUN-uWnRq--6Xyk0w1Kw@mail.gmail.com
Whole thread Raw
In response to Re: doc phrase: "inheritance child"  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Responses Re: doc phrase: "inheritance child"  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
>        <para>
> -       If true, the stats include inheritance child columns, not just the
> +       If true, the stats include child tables, not just the
>
> We are replacing columns with tables; is that intentional?
>
> Partitioned tables do not have their own stats, it's just aggregated partition stats.
> ...
> -       If true, the stats include inheritance child columns, not just the
> +       If true, the stats include child childs, not just the
>         values in the specified relation
>        </para></entry>
>       </row>
> @@ -13152,7 +13152,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
>         <structfield>inherited</structfield> <type>bool</type>
>        </para>
>        <para>
> -       If true, this row includes inheritance child columns, not just the
> +       If true, this row includes child tables, not just the
>         values in the specified table
>        </para></entry>
>       </row>
>
> Replacing inheritance child "column" with "tables", is that intentional?

I was a bit confused by these too, though perhaps the original text is
not as clear as it could be?  Would the following be a good rewrite:

If true, the stats cover the contents not only of the specified table,
but also of its child tables or partitions.  (If the table is
partitioned, which contains no data by itself, the stats only cover
the contents of partitions).

Although, maybe the parenthetical is unnecessary.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: bogus: logical replication rows/cols combinations
Next
From: Yugo NAGATA
Date:
Subject: Prevent writes on large objects in read-only transactions