Re: makeAndExpr(), etc. confined to gram.y? - Mailing list pgsql-hackers

From Amit Langote
Subject Re: makeAndExpr(), etc. confined to gram.y?
Date
Msg-id CA+HiwqEj926DgrxQ7g1Xik9mzd1uqOZja9GTZxMrBOdLmcqsRg@mail.gmail.com
Whole thread Raw
In response to Re: makeAndExpr(), etc. confined to gram.y?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Jun 26, 2014 at 12:46 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
>> Yeah, that is true. Sorry, I am unaware as to how generic make*
>> functions in gram.y are and how they differ from those in makefuncs.c.
>
>> So, use of make* family of functions outside parser is their abuse in
>> some way? Anything that needs to use these functions should somehow be
>> accomplished in parser perhaps. For example, duplicate/redundant CHECK
>> expressions elimination and such?
>
> Well, the larger point here is that those functions are specific to
> gram.y's problem of constructing multi-AND(OR) structures during a series
> of binary production actions.  I don't see that there's any use for them
> elsewhere, and the way that they modify the input structures wouldn't
> necessarily be safe anywhere else either.
>

I see. Thanks for clarifying.

--
Amit



pgsql-hackers by date:

Previous
From: John Lumby
Date:
Subject: Re: Extended Prefetching using Asynchronous IO - proposal and patch
Next
From: Robert Haas
Date:
Subject: Re: better atomics - v0.5