Re: doc phrase: "inheritance child" - Mailing list pgsql-hackers

From Amit Langote
Subject Re: doc phrase: "inheritance child"
Date
Msg-id CA+HiwqEj5Nudu4fGnrH08yvsQz9NGN_XXRUMEcGjfVcG5S2zuA@mail.gmail.com
Whole thread Raw
In response to Re: doc phrase: "inheritance child"  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
On Thu, Jun 30, 2022 at 6:55 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> On Fri, May 27, 2022 at 03:22:38PM +0900, Amit Langote wrote:
> > On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote:
> > >        <para>
> > > -       If true, the stats include inheritance child columns, not just the
> > > +       If true, the stats include child tables, not just the
> > >
> > > We are replacing columns with tables; is that intentional?
> > >
> > > Partitioned tables do not have their own stats, it's just aggregated partition stats.
> > > ...
> > > -       If true, the stats include inheritance child columns, not just the
> > > +       If true, the stats include child childs, not just the
> > >         values in the specified relation
> > >        </para></entry>
> > >       </row>
> > > @@ -13152,7 +13152,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
> > >         <structfield>inherited</structfield> <type>bool</type>
> > >        </para>
> > >        <para>
> > > -       If true, this row includes inheritance child columns, not just the
> > > +       If true, this row includes child tables, not just the
> > >         values in the specified table
> > >        </para></entry>
> > >       </row>
> > >
> > > Replacing inheritance child "column" with "tables", is that intentional?
> >
> > I was a bit confused by these too, though perhaps the original text is
> > not as clear as it could be?  Would the following be a good rewrite:
>
> I updated the language to say "values from".  Is this better ?

Yes.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum
Next
From: Bharath Rupireddy
Date:
Subject: Re: Patch proposal: New hooks in the connection path