Re: logical/relation.c header description - Mailing list pgsql-hackers

From Amit Langote
Subject Re: logical/relation.c header description
Date
Msg-id CA+HiwqEdiiF9UP58MBOmjM=qr_kG0zvRQ32JPrPVUTLo9_FgTQ@mail.gmail.com
Whole thread Raw
In response to Re: logical/relation.c header description  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: logical/relation.c header description
List pgsql-hackers
Thanks for taking a look.

On Thu, Sep 17, 2020 at 9:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Thu, Sep 17, 2020 at 3:22 PM Amit Langote <amitlangote09@gmail.com> wrote:
> >
>
>  /*-------------------------------------------------------------------------
>   * relation.c
> - *    PostgreSQL logical replication
> + *    PostgreSQL logical replication relation mapping routines
>   *
> ..
>  * NOTES
>  *   This file contains helper functions for logical replication relation
>  *   mapping cache.
>
> The new header title and NOTES section say the almost same thing. How
> about changing the title as "PostgreSQL logical replication relation
> mapping cache" and remove the NOTES section.

That makes sense.

Actually, I did consider expanding that NOTE to mention what the
module does but there are not actually that many interesting things in
there.  If you would like to take a look at the text I had come up
with, please check the attached.

-- 
Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: "k.jamison@fujitsu.com"
Date:
Subject: RE: [Patch] Optimize dropping of relation buffers using dlist
Next
From: Jakub Wartak
Date:
Subject: Re: Parallelize stream replication process