Re: Autovacuum on partitioned table - Mailing list pgsql-hackers

From Amit Langote
Subject Re: Autovacuum on partitioned table
Date
Msg-id CA+HiwqE=TjzwOhps8L5pQkMX7MbY0THZR5czcqCis3U27LwwwQ@mail.gmail.com
Whole thread Raw
In response to Re: Autovacuum on partitioned table  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: Autovacuum on partitioned table
List pgsql-hackers
On Thu, Feb 20, 2020 at 4:50 PM Amit Langote <amitlangote09@gmail.com> wrote:
> * I may be missing something, but why doesn't do_autovacuum() fetch a
> partitioned table's entry from pgstat instead of fetching that for
> individual children and adding? That is, why do we need to do the
> following:
>
> +            /*
> +             * If the relation is a partitioned table, we check it
> using reltuples
> +             * added up childrens' and changes_since_analyze tracked
> by stats collector.

Oh, it's only adding up children's pg_class.reltuple, not pgstat
stats.  We need to do that because a partitioned table's
pg_class.reltuples is always 0 and correctly so.  Sorry for not
reading the patch properly.

Thanks,
Amit



pgsql-hackers by date:

Previous
From: "asaba.takanori@fujitsu.com"
Date:
Subject: RE: Complete data erasure
Next
From: Peter Eisentraut
Date:
Subject: Re: client-side fsync() error handling