Re: [PATCH] Fix Null pointer dereferences (pgoutput.c) - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [PATCH] Fix Null pointer dereferences (pgoutput.c)
Date
Msg-id CA+HiwqE47YCm8r8RH36ZzaQTArBEhQBfaDCXex03=hdxtsughA@mail.gmail.com
Whole thread Raw
In response to [PATCH] Fix Null pointer dereferences (pgoutput.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On Thu, Apr 23, 2020 at 10:48 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi,
>
> Per Coverity.
>
> If test oldtuple can be NULL, I mean it can really be NULL.
> On DELETE process, if oldtuple is NULL, log error and continue.
> So UPDATE must have the same treatment.

I think I too had noticed this when working on my patch to move this
code to a different location in that function, posted here:
https://www.postgresql.org/message-id/CA%2BHiwqEeU19iQgjN6HF1HTPU0L5%2BJxyS5CmxaOVGNXBAfUY06Q%40mail.gmail.com

-- 
Amit Langote
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: More efficient RI checks - take 2
Next
From: Tom Lane
Date:
Subject: Re: Poll: are people okay with function/operator table redesign?