Home > mailing lists

Accidental assignment instead of compare in GetOperatorFromCompareType? - Mailing list pgsql-hackers

From	Jacob Brazeal
Subject	Accidental assignment instead of compare in GetOperatorFromCompareType?
Date	March 3 08:05:47
Msg-id	CA+COZaC-JMbhQ4O0Q8V1Bxa0R+Nex_RN9D6UyuLPiEx_CK4Heg@mail.gmail.com Whole thread Raw
Responses	Re: Accidental assignment instead of compare in GetOperatorFromCompareType? Re: Accidental assignment instead of compare in GetOperatorFromCompareType?
List	pgsql-hackers

Hi all,

It looks like commit 630f9a43cece93cb4a5c243b30e34abce6a89514 omitted an equals sign in an ereport() in GetOperatorFromCompareType, giving the line:

cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator for type %s", format_type_be(opcintype)) :

I think the impact is just that we'd never see the error messages for the COMPARE_OVERLAP and COMPARE_CONTAINED_BY cases logged.

Regards,

Jacob

From: Michael Paquier
Date: 03 March, 07:13:05
Subject: Re: Add assertion for failed alloc to palloc0() and palloc_extended()

From: Jacob Brazeal
Date: 03 March, 08:06:18
Subject: Re: Accidental assignment instead of compare in GetOperatorFromCompareType?