Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #15977: Inconsistent behavior in chained transactions - Mailing list pgsql-hackers

From fn ln
Subject Re: BUG #15977: Inconsistent behavior in chained transactions
Date
Msg-id CA+99BHqVJC-ZPaDW5Lmyj5q3wS0tvmYNo+xLoG8ANp7jzZ+gwg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #15977: Inconsistent behavior in chained transactions  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view
We have three options:
  1. Prohibit AND CHAIN outside a transaction block, but do nothing in plain COMMIT/ROLLBACK or AND NO CHAIN.
  2. Deal "there is no transaction in progress" (and "there is already a transaction in progress" if needed) as an error.
  3. Leave as it is.

Option 1 makes overall behavior more inconsistent, and option 2 might cause the backward-compatibility issues.
So I think 3 is a better solution for now.

2019年9月3日(火) 18:55 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:
On 2019-08-29 16:58, Fabien COELHO wrote:
>
>> Thanks, I got it. I have never made a patch before so I'll keep it in my
>> mind. Self-contained patch is now attached.
>
> v3 applies, compiles, "make check" ok.
>
> I turned it ready on the app.

Should we make it an error instead of a warning?

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Locking a row with KEY SHARE NOWAIT blocks
Next
From: Tom Lane
Date:
Subject: Re: Locking a row with KEY SHARE NOWAIT blocks