Re: Crash during backend start when low on memory - Mailing list pgsql-bugs

From Mats Kindahl
Subject Re: Crash during backend start when low on memory
Date
Msg-id CA+14427pjo8-V2z+Rv5S6JL2-1JXzhQ0t_FkBaEx13_H7sPLdg@mail.gmail.com
Whole thread Raw
In response to Re: Crash during backend start when low on memory  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Crash during backend start when low on memory  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Mon, Jan 16, 2023 at 9:58 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Mats Kindahl <mats@timescale.com> writes:
> On Fri, Jan 13, 2023 at 4:01 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, the BackendStartup change is 100% wrong; it is replacing
>> perfectly good code that recovers correctly with bad code that
>> will take down the postmaster (not a backend child!) on OOM.

> AFAICT, the error is caught by the caller (using PG_TRY), executes some
> cleanup code, and then continues executing, so it shouldn't take down the
> postmaster.

There are no PG_TRY blocks in the postmaster, and certainly no recovery.

I added one in the patch. Doesn't this work? It seemed to work when I tried it.

Best wishes,
Mats Kindahl


                        regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: Crash during backend start when low on memory
Next
From: Tom Lane
Date:
Subject: Re: Crash during backend start when low on memory