Re: Portal->commandTag as an enum - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: Portal->commandTag as an enum
Date
Msg-id C1EF53B4-BE38-4D7F-8DF8-4363876415AF@enterprisedb.com
Whole thread Raw
In response to Re: Portal->commandTag as an enum  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Portal->commandTag as an enum
List pgsql-hackers

> On Feb 11, 2020, at 1:02 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> On 2020-Feb-11, Mark Dilger wrote:
>
>>> No thanks.
>>
>> I’m not sure which option you are voting for:
>>
>> (Option #1) Have the perl script generate the .c and .h file from a .dat file
>>
>> (Option #2) Have the perl script validate but not generate the .c and .h files
>>
>> (Option #3) Have no perl script, with all burden on the programmer to get the .c and .h files right by hand.
>>
>> I think you’re voting against #3, and I’m guessing you’re voting for #1, but I’m not certain.
>
> I was voting against #2 (burden the programmer with consistency checks
> that must be fixed by hand, without actually doing the programmatically-
> doable work), but I don't like #3 either.  I do like #1.

Option #1 works for me.  If I don’t see any contrary votes before I get back to this patch, I’ll implement it that way
forthe next version. 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Portal->commandTag as an enum
Next
From: Andrew Dunstan
Date:
Subject: Re: Postgres 32 bits client compilation fail. Win32 bits client issupported?