Re: Fix typo in comment - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix typo in comment
Date
Msg-id C09888E5-1462-429D-8BCE-B4256FA18436@yesql.se
Whole thread Raw
In response to Re: Fix typo in comment  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
> On 6 May 2022, at 14:50, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> On 2022-May-06, Zaorang Yang wrote:
> 
>> Maybe, the first letter of comments in postinit.c should be capitalized.
> 
> Hmm, typically these one-line comments are not "full sentences", so they
> don't have capitals and no ending periods either.  I wouldn't like the
> endless stream of patches that would result if we let this go in.

Agreed. A quick grep turns up a fair number of such comments:

 $ git grep "^\s*\/\* [a-z].\+\*\/$" src/ | wc -l
   16588

If anything should be done to this it would perhaps be better to add to
pgindent or a similar automated process.  If anything.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Fix typo in comment
Next
From: Matheus Alcantara
Date:
Subject: Trying to add more tests to gistbuild.c