Re: Fix misaligned access of ItemPointerData on ARM - Mailing list pgsql-hackers

From Piotr Stefaniak
Subject Re: Fix misaligned access of ItemPointerData on ARM
Date
Msg-id BLU436-SMTP2125686ED51F61A8B24E1FF2C10@phx.gbl
Whole thread Raw
In response to Re: Fix misaligned access of ItemPointerData on ARM  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fix misaligned access of ItemPointerData on ARM
List pgsql-hackers
On 05/21/2015 10:08 PM, Tom Lane wrote:
> It's not clear to me whether all compilers that accept "packed" also
> accept "aligned", but there are enough ARM machines in the buildfarm
> that we could hope that we'll find out if this isn't portable.

I think src/include/c.h:614 onward, in its current state, guarantees that?

/* GCC, Sunpro and XLC support aligned, packed and noreturn */
#if defined(__GNUC__) || defined(__SUNPRO_C) || defined(__IBMC__)
#define pg_attribute_aligned(a) __attribute__((aligned(a)))
#define pg_attribute_noreturn() __attribute__((noreturn))
#define pg_attribute_packed() __attribute__((packed))
#define HAVE_PG_ATTRIBUTE_NORETURN 1
#else



pgsql-hackers by date:

Previous
From: Geoff Winkless
Date:
Subject: Re: INSERT ... ON CONFLICT DO UPDATE with _any_ constraint
Next
From: Tom Lane
Date:
Subject: Re: Fix misaligned access of ItemPointerData on ARM