RE: Proposal for Updating CRC32C with AVX-512 Algorithm. - Mailing list pgsql-hackers

From Amonson, Paul D
Subject RE: Proposal for Updating CRC32C with AVX-512 Algorithm.
Date
Msg-id BL1PR11MB530420CA393530170BADB49ADCC02@BL1PR11MB5304.namprd11.prod.outlook.com
Whole thread Raw
In response to Re: Proposal for Updating CRC32C with AVX-512 Algorithm.  (Andres Freund <andres@anarazel.de>)
Responses Re: Proposal for Updating CRC32C with AVX-512 Algorithm.
List pgsql-hackers
> -----Original Message-----
> From: Andres Freund <andres@anarazel.de>
> Sent: Wednesday, June 12, 2024 1:12 PM
> To: Amonson, Paul D <paul.d.amonson@intel.com>

> FWIW, I tried the v2 patch on my Xeon Gold 5215 workstation, and dies early
> on with SIGILL:

Nice catch!!!  I was testing the bit for the vpclmulqdq in EBX instead of the correct ECX register. New Patch attached.
Iadded defines to make that easier to see those types of bugs rather than a simple index number. I double checked the
othersas well. 

Paul


Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Harmonizing pg_bsd_indent parameter names
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: RFC: adding pytest as a supported test framework