Re: WIP: Triggers on VIEWs - Mailing list pgsql-hackers

From David Christensen
Subject Re: WIP: Triggers on VIEWs
Date
Msg-id BF60FEBD-B00D-4E32-AA5C-D672D3185859@endpoint.com
Whole thread Raw
In response to Re: WIP: Triggers on VIEWs  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: WIP: Triggers on VIEWs  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
On Sep 5, 2010, at 3:09 AM, Dean Rasheed wrote:

> On 15 August 2010 18:38, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>> Here is a WIP patch implementing triggers on VIEWs ... <snip>
>>
>> There are still a number of things left todo:
>>  - extend ALTER VIEW with enable/disable trigger commands
>>  - much more testing
>>  - documentation
>>
>
> Attached is an updated patch with more tests and docs, and a few minor


At least for me, there are some portions of the docs which could use some formatting changes in order to not be
confusinggrammatically; e.g., this was confusing to me on the first read: 

-    trigger name.  In the case of before triggers, the
+    trigger name.  In the case of before and instead of triggers, the

I realize this lack of formatting was inherited from the existing docs, but this would make more sense to me if this
(andpresumably the other related instances of "before" and "after") were set apart with <literal></> or similar.  This
isalready in use in some places in this patch, so seems like the correct markup. 

Regards,

David
--
David Christensen
End Point Corporation
david@endpoint.com






pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: knngist - 0.8
Next
From: Robert Haas
Date:
Subject: update on global temporary and unlogged tables