Re: psql: show only failed queries - Mailing list pgsql-hackers

<div class="WordSection1"><p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">On</span><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">30June 2014 12:24, Pavel Stehule Wrote:</span><p
class="MsoNormal"><spanstyle="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif"">>>Ihave reviewed this patch. Please find my review
commentsbelow:</span><p><span
style="font-size:9.5pt;font-family:"Arial","sans-serif";color:black">>>1.</span><span
style="font-size:7.0pt;color:black">    </span><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Commandstart-up option (e.g. -a/--echo-all for --ECHO=all),
fornew functionality is not provided.</span><p class="MsoNormal" style="margin-bottom:12.0pt">>all not options
enteredvia psql variables has psql option and psql comment. I'll plan add new decription to --help-variables list.<p
class="MsoNormal">>Ifit is necessary I can add long option --echo-errors, I didn't a good char for short option. Any
idea?<pclass="MsoNormal"> <p class="MsoNormal">But the new option we are adding are on a track of existing option, so
betterwe add start-up option for this also.<p class="MsoNormal">Yeah long option –echo-errors seems to be fine to me
also.For short option, I think we can use “-b” stands for blunder. This is the closest one I could think of.<p
class="MsoNormal"> <p><spanstyle="font-size:9.5pt;font-family:"Arial","sans-serif";color:black">>>2.</span><span
style="font-size:7.0pt;color:black">    </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">New
Commandstart-up option should be added in "psql --help" as well as in documentation.</span><p
class="MsoNormal">>dependson previous, <p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Right.</span><pclass="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">>>Alsoas I understand, this new option is kind of
sub-setof existing option (ECHO=query), so should not we display</span><p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">>>querystring in the same format as it was getting
printedearlier.</span><p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">>>ThoughI also feel that prefixing query with
STATEMENTword will be helpful to grep but at the same time I am worried</span><p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">>>aboutinconsistency with existing option.
  </span><pclass="MsoNormal"> <p class="MsoNormal" style="margin-bottom:12.0pt">>This is question. And I am not
strongin feeling what should be preferred. But still I am inclined to prefer a variant with STATEMENT prefix. Mode with
-ais used with different purpose than mode "show errors only" - and output with prefix is much <p class="MsoNormal"
style="margin-bottom:12.0pt">>more consistent with log entry - and displaying error. So I agree, so there is
potentialinconsistency (but nowhere is output defined), but this output is more practical, when you are concentrated to
error'sprocessing. <p class="MsoNormal" style="margin-bottom:12.0pt">Yeah right, I just wanted to raise point to
provokeother thought to see if anyone having different opinion. If no objection from others, we can go ahead with the
currentprefixing approach.<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"></span><p
class="MsoNormal"><i><spanstyle="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">Thanks and
Regards,</span></i><pclass="MsoNormal"><i><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">KumarRajeev Rastogi</span></i><i><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"></span></i></div>