Hello Fabien,
Sorry for not responding for long time.
> Two typos:
> - "usinng" -> "using"
> - "a rejection method used" -> "a rejection method is used"
>
> I'm not sure of "least_recently_used_i", this naming style is not used in pgbench. "least_recently_used" would be ok.
>
> "..nb_cells.. != ZIPF_CACHE_SIZE", ISTM that "<" is more logical,
> even if the result is the same?
Fixed.
> Maybe the cache overflow could be counted, to allow for a possible warning message in the final report?
Also done. But one question: Should it be done by printing to stdout or stderr ?
> When/if the pgbench tap test patch get through, coverage tests should
> be added.
I have added few tests and I am not sure if they OK or not. It was my first experience with perl and tests in
PostgreSQL.
—
Thanks and Regards,
Alik Khilazhev
Postgres Professional:
http://www.postgrespro.com
The Russian Postgres Company
