Re: [PATCH] Query Jumbling for CALL and SET utility statements - Mailing list pgsql-hackers

From Imseih (AWS), Sami
Subject Re: [PATCH] Query Jumbling for CALL and SET utility statements
Date
Msg-id BBB9A13D-BBE2-44A4-9CA7-6E189120E5A2@amazon.com
Whole thread Raw
In response to Re: [PATCH] Query Jumbling for CALL and SET utility statements  ("Drouvot, Bertrand" <bdrouvot@amazon.com>)
Responses Re: [PATCH] Query Jumbling for CALL and SET utility statements
List pgsql-hackers

> Please find attached v2 as an attempt to do so.

+1 to the idea.

I think it will be better to evaluate jstate instead of

JUMBLE_UTILITY, such as:

 

if (query->utilityStmt && !jstate)

 

instead of

 

if (query->utilityStmt && !JUMBLE_UTILITY(query->utilityStmt))

 

This will allow for support of potentially other utility statements

In the future without having to teach pg_stat_statements about them.

If a jstate is set for the utility statements, pgss will do the right thing.

 

 

Thanks

 

--

Sami Imseih

Amazon Web Services (AWS)

 

 

 

 

 

 

 

 

 

 

pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: [PATCH v1] fix potential memory leak in untransformRelOptions
Next
From: Jehan-Guillaume de Rorthais
Date:
Subject: [BUG] wrong FK constraint name when colliding name on ATTACH