Re: Fixing build of MSVC with OpenSSL 3.0.0 - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fixing build of MSVC with OpenSSL 3.0.0
Date
Msg-id BB22F576-9587-48E5-9E1A-803D574F09D6@yesql.se
Whole thread Raw
In response to Fixing build of MSVC with OpenSSL 3.0.0  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Fixing build of MSVC with OpenSSL 3.0.0  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 19 Oct 2021, at 07:27, Michael Paquier <michael@paquier.xyz> wrote:

> Looking at the MSIs of OpenSSL for Win64 and Win32, there are no
> changes in the deliverable names or paths, meaning that something as
> simple as the attached patch is enough to make the build pass.

Makes sense.

> Any opinions?

I think we can tighten the check for GetOpenSSLVersion() a bit since we now now
the range of version in the 1.x.x series.  For these checks we know we want
1.1.x or 3.x.x, but never 2.x.x etc.

How about the (untested) attached which encodes that knowledge, as well as dies
on too old OpenSSL versions?

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Andrew Bille
Date:
Subject: Re: [Proposal] Global temporary tables
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: [PATCH] Prefer getenv("HOME") to find the UNIX home directory