Re: This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function. - Mailing list pgsql-odbc

From developer rohto
Subject Re: This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.
Date
Msg-id BAY178-W1994AB978B10070DAF58CCC4730@phx.gbl
Whole thread Raw
In response to Re: This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.  (developer rohto <rohtodeveloper@outlook.com>)
List pgsql-odbc
Dear Michael, Inoue

Thanks very much.
Postgres process still crash  after solution2(symbols_conflict.patch) applied. 
So the other solution(solution1(20141029_pgodbc_rename_check_encoding.patch)) was perfered.
Right?

regards,
developer rohto

From: rohtodeveloper@outlook.com
To: michael.paquier@gmail.com
CC: inoue@tpf.co.jp; pgsql-odbc@postgresql.org
Subject: RE: [ODBC] This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.
Date: Thu, 13 Nov 2014 07:09:50 +0000

I think the solution2(symbols_conflict.patch) may not be able to solve the problem。 
The solution2 is trying to make the odbc’s check_client_encoding() function into a local function. 
However, the postgres's check_client_encoding() function is still a global function. 
When the odbc driver is trying to call the check_client_encoding() function, while the postgres's check_client_encoding() function is still being exposed , 

the postgres's check_client_encoding() may still have a chance to be called by the odbc driver ,and cause the postgres process to crash.


Date: Mon, 3 Nov 2014 15:52:06 +0900
Subject: Re: Re: [ODBC] This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.
From: michael.paquier@gmail.com
To: rohtodeveloper@outlook.com
CC: inoue@tpf.co.jp; pgsql-odbc@postgresql.org



On Mon, Nov 3, 2014 at 3:26 PM, developer rohto <rohtodeveloper@outlook.com> wrote:
Thanks very much.
We decide to use your solution1(20141029_pgodbc_rename_check_encoding.patch).
On the other hand, by the way, which solution does the community prefer to choose?
The potential solution by Inoue-san to reduce dependencies between library objects is better.
--
Michael

pgsql-odbc by date:

Previous
From: Pavel Raiskup
Date:
Subject: Re: psqlODBC 09.03.0400 Released
Next
From: developer rohto
Date:
Subject: Pgodbc is thread safe?