When saying:
"Please submit the changes as patches, instead of the whole files".
Do you mean to send each file seperately? or other issues as well?
The change was test and design for 8.1.14, but as far as I see it is also true for any other version.
Of course merge is needed in case that the files were changed since then, however , due to the fact that it is only few rows it will be easy to do it.
Alvaro wrote:
"it may be useful to lose the redirection only on the cases where it fails, so we still have reasonable behavior on non-broken
platforms"
Nice idea, but it is really doesn't matter: on other platform than win32, the code left unchanged! the fix is only relevant for win32 on which (as I explained) the MSI installer (if used) redirect the output by default to a log file.
Regards
Dror
> Date: Mon, 14 Aug 2006 12:40:25 -0400
> From: alvherre@commandprompt.com
> To: dror_b@hotmail.com
> CC: pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003
>
> dror wrote:
>
> > There were two options to solve this issue:
> >
> > Create a new file , grant a write permission for the Postgres user
> > and redirect the output to that file. (EnterpriseDB use this method)
> > Canceling the redirection at all.
> >
> > I choose the second option and omit the redirection in any case that
> > it windows machine and the redirection was sent to DEVNULL.
> >
> > The only files that I changed are: initDB.c, exec.c and pg_ctl.c
>
> Please submit the changes as patches, instead of the whole files. Also,
> please specify which branch do these patches apply -- is this for 8.1,
> or for the current development code? When checked against the 8.1
> pg_ctl.c, the file you sent only contains a regression for a bug fix,
> and no change related to what you describe above.
>
> On the other hand, it may be useful to lose the redirection only on the
> cases where it fails, so we still have reasonable behavior on non-broken
> platforms. Or maybe there's a better solution.
>
> --
> Alvaro Herrera http://www.CommandPrompt.com/
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Express yourself instantly with Windows Live Messenger!
Windows Live Messenger!
