Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales - Mailing list pgadmin-hackers

From Nikhil S
Subject Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales
Date
Msg-id BANLkTinx4i7jfZxhEcOiLwMYkqq5hYm1xA@mail.gmail.com
Whole thread Raw
In response to pgadmin III - "Display objects" part of database restore errors out in non-English locales  (Nikhil S <nixmisc@gmail.com>)
Responses Re: Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales
List pgadmin-hackers
Please ignore the last patch. Some unwanted debug changes in there!
Please use this one.

Regards,
Nikhils

On Wed, May 18, 2011 at 5:28 PM, Nikhil S <nixmisc@gmail.com> wrote:
Hi,

So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore into a database using a backup from earlier. When I click on "Display objects" tab, I see an error being displayed, although the actual restore happens just fine. Note that no error occurs in English locales.

Took me a while to figure this one out. The issue is with frmRestore::OnEndProcess() function. It naively avoids lines containing ";" or "P" as the first letter. So in the English locale, the last line about the "Process returned exit code 0" is handled. However in other locales, this will be translated and hence the last line will be inspected leading to a spurious error.

The fix is to avoid inspecting the last line. The attached patch does that.

Regards,
Nikhils

Attachment

pgadmin-hackers by date:

Previous
From: Nikhil S
Date:
Subject: pgadmin III - "Display objects" part of database restore errors out in non-English locales
Next
From: Guillaume Lelarge
Date:
Subject: Re: A question about database designer first deliverable