2011/6/28 Alvaro Herrera <alvherre@commandprompt.com>:
> Excerpts from Pavel Stehule's message of dom jun 26 13:10:13 -0400 2011:
>> Hello
>>
>> >
>> > I have touched next_token() and next_token_expand() a bit more, because
>> > it seemed to me that they could be simplified further (the bit about
>> > returning the comma in the token, instead of being a boolean return,
>> > seemed strange). Please let me know what you think.
>>
>> I am thinking, so it is ok.
>
> Thanks, I have pushed it. Brendan: thanks for the patch.
>
>> I am not sure, if load_ident is correct. In load_hba you clean a
>> previous context after successful processing. In load_ident you clean
>> data on start. Is it ok?
>
> Yeah, they are a bit inconsistent. I am uninclined to mess with it,
> though. Right now it seems to me that the only way it could fail is if
> you hit an out-of-memory or a similar problem. And if you hit that at
> postmaster startup ... well ... I guess you have A Problem.
there should be a format (syntax) error. If somebody breaks a pg_ident
and will do a reload, then all ident mapping is lost.
This is not related to topic or doesn't modify current behave, so
should not be repaired now
Pavel
>
> If somebody wants to submit a patch to fix that, be my guest.
>
> --
> Álvaro Herrera <alvherre@commandprompt.com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>
