On Sun, Jun 19, 2011 at 3:30 PM, Greg Smith <greg@2ndquadrant.com> wrote:
...
>
> Things to fix in the patch before it would be a commit candidate:
>
> -Adjust the loop size/name, per above
> -Reformat some of the longer lines to try and respect the implied right
> margin in the code formatting
> -Don't include the "plgsql function created." line unless in debugging mode.
> -Add the docs. Focus on how this measures how fast the database can execute
> SELECT statements using server-side code. An explanation that the
> "transaction" block size is 512 is important to share. It also needs a
> warning that time based runs ("-T") may have to wait for a block to finish
> and go beyond its normally expected end time.
> -The word "via" in the "transaction type" output description is probably not
> the best choice. Changing to "SELECT only using PL/pgSQL" would translate
> better, and follow the standard case use for the name of that language.
Hi Greg,
Thanks for the review. I've realized that I will not get a chance to
incorporate these changes during this commitfest due to work and
travel schedules, so I have changed it to "Returned with Feedback" and
will update it for the next commitfest.
One more thought I had, would it make sense to change this from the
creation of a PL/pgSQL permanent function to instead use the recently
added DO anonymous block syntax? I think that would be somewhat
cleaner about leaving cruft behind in the database. But it would
increase the overhead of each outer execution, and would also mean
that it would not be backwards compatible to run against servers
before 9.0
Cheers,
Jeff
