Hi Guillaume,
I've tweaked the wording on the message in this patch as I wasn't
entirely happy with the phrasing, but whilst doing so I noticed there
doesn't seem to be any error checking to handle the case where the
extension cannot be installed (for example, because the user is using
a hosting site which hasn't installed the contrib modules).
There's also no way to permanently suppress the message box, which
could become very annoying.
Final thought - we also have a guru hint about the admin pack
(instrumentation.html). Shouldn't this patch touch the same places as
that hint (as well as anywhere else it makes sense)?
On Mon, Apr 18, 2011 at 9:23 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Install adminpack on user request in frmStatus
>
> Now that we can install an extension quite easily, it's simpler to ask the
> user if he wants pgAdmin to install it, rather than displaying him a hint. We
> still do that if it's not an 9.1 server or if the server doesn't have the
> adminpack extension installed.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bd13fc270aaf7fdf007c7ea94969c1fbfeb4f9fe
>
> Modified Files
> --------------
> pgadmin/db/pgConn.cpp | 4 ++--
> pgadmin/frm/frmStatus.cpp | 30 ++++++++++++++++++++++++++----
> pgadmin/include/db/pgConn.h | 2 +-
> 3 files changed, 29 insertions(+), 7 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
