On Wed, Jun 15, 2011 at 4:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Dean Rasheed <dean.a.rasheed@gmail.com> writes:
>> On 15 June 2011 07:56, Jaime Casanova <jaime@2ndquadrant.com> wrote:
>>> Testing the CHECK NOT VALID patch i found $subject... is this intended?
>
>> Aside from the ugliness of the code, we can't just add a
>> ConstraintAttributeSpec to the second block, because that would
>> enforce an order to these options.
>
>> OTOH adding NOT VALID to ConstraintAttributeSpec is a bit invasive,
>> since it's used in quite a few places, including CREATE TABLE, where
>> NOT VALID is never allowed.
>
>> Thoughts?
>
> I think we need to do the second one, ie, add it to
> ConstraintAttributeSpec and do what's necessary to filter later.
> The reason we have a problem here is exactly that somebody took
> shortcuts.
There were grammar issues in the NOT VALID patch which I sought to
resolve. Those new suggestions may fall foul of the same issues.
I raised that point and asked for input prior to commit.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
