Re: possible connection leak in dblink? - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: possible connection leak in dblink?
Date
Msg-id BANLkTikUyAQRqgA6uWxRZ3TvyhjGzZkP-A@mail.gmail.com
Whole thread Raw
In response to Re: possible connection leak in dblink?  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Wed, Jun 15, 2011 at 11:41, Fujii Masao <masao.fujii@gmail.com> wrote:
> ISTM that the root problem is that dblink_send_query calls DBLINK_GET_CONN
> though it doesn't accept the connection string as an argument.

+1 for the fix. I have the same conclusion at the first glance.

> Since the first
> argument in dblink_send_query must be the connection name, dblink_send_query
> should call DBLINK_GET_NAMED_CONN instead. The variable 'freeconn' is used
> only when DBLINK_GET_CONN is called. So, if dblink_send_query uses
> DBLINK_GET_NAMED_CONN instead, the variable 'freeconn' is no longer necessary.
>
> The similar problem exists in dblink_get_result and dblink_record_internal.
> Attached patch fixes those problems.

-- 
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Why polecat and colugos are failing to build back branches
Next
From: Bruce Momjian
Date:
Subject: pg_upgrade using appname to lock out other users