pg_dump vs malloc - Mailing list pgsql-hackers

From Magnus Hagander
Subject pg_dump vs malloc
Date
Msg-id BANLkTi=tJFG8av_V+ePe6TSi8-XDj=_dVg@mail.gmail.com
Whole thread Raw
Responses Re: pg_dump vs malloc
List pgsql-hackers
I came across a situation today with a pretty bad crash of pg_dump,
due to not checking the return code from malloc(). When looking
through the code, it seems there are a *lot* of places in pg_dump that
doesn't check the malloc return code.

But we do have a pg_malloc() function in there - but from what I can
tell it's only used very sparsely?

Shouldn't we be using that one more or less everywhere, or even #define it?

Or am I missing something in the code here?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: TG_DEPTH patch v1
Next
From: Tom Lane
Date:
Subject: Re: gcc 4.6 and hot standby