Re: FDW table hints - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: FDW table hints
Date
Msg-id BANLkTi=BzJzZJZKKQ1mrQzgOLC+21xOTww@mail.gmail.com
Whole thread Raw
In response to Re: FDW table hints  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: FDW table hints  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Thu, May 5, 2011 at 19:22, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Since I brought it up - a patch along this line?
>
> Please don't capitalize "foreign table" there.

Yeah, I was a bit split about that myself. Will change.


> Also, I think an "else" before the other ereport would make the code
> clearer, even though it's not strictly necessary.

Agreed.

Unless someone objects, I'll go put that in later tonight. (along with
a comment on why there are two different msgs)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: FDW table hints
Next
From: Bruce Momjian
Date:
Subject: Re: Patch to improve style of generate_history.pl perl script