TLS checking in pgstat - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject TLS checking in pgstat
Date
Msg-id B88BC38F-BBF1-4755-976E-F8418667656D@yesql.se
Whole thread Raw
Responses Re: TLS checking in pgstat  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
As I mentioned in [1], checking (struct Port)->ssl for NULL to determine
whether TLS is used for connection is a bit of a leaky abstraction, as that's
an OpenSSL specific struct member.  This sets the requirement that all TLS
implementations use a pointer named SSL, and that the pointer is set to NULL in
case of a failed connection, which may or may not fit.

Is there a reason to not use (struct Port)->ssl_in_use flag which tracks just
what we're looking for here?  This also maps against other parts of the
abstraction in be-secure.c which do just that.  The attached implements this.

cheers ./daniel

[1] FAB21FC8-0F62-434F-AA78-6BD9336D630A@yesql.se


Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Commitfest 2020-07
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Custom compression methods