Re: Faster StrNCpy - Mailing list pgsql-hackers

From Strong, David
Subject Re: Faster StrNCpy
Date
Msg-id B6419AF36AC8524082E1BC17DA2506E802579E0F@USMV-EXCH2.na.uis.unisys.com
Whole thread Raw
In response to Faster StrNCpy  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Faster StrNCpy
List pgsql-hackers
We sometimes see TupleDescInitEntry () taking high CPU times via OProfile. This does include, amongst a lot of other
code,a call to namestrcpy () which in turn calls StrNCpy (). Perhaps this is not a good candidate right now as a name
stringis only 64 bytes. 
David

________________________________

From: pgsql-hackers-owner@postgresql.org on behalf of Tom Lane
Sent: Wed 9/27/2006 6:49 AM
To: Andrew Dunstan
Cc: josh@agliodbs.com; pgsql-hackers@postgresql.org; Neil Conway; Martijn van Oosterhout
Subject: Re: [HACKERS] Faster StrNCpy



Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> What I'd like to do immediately is put in strlcpy() and hit the two or
>> three places I think are performance-relevant.

> What are the other hotspots?

The ones I can think of offhand are set_ps_display and use of strncpy as
a HashCopyFunc.
                       regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings




pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Buildfarm alarms
Next
From: Tom Lane
Date:
Subject: Re: Block B-Tree concept