Re: Supply restore_command to pg_rewind via CLI argument - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Supply restore_command to pg_rewind via CLI argument
Date
Msg-id B593FE3D-324A-4A9A-AEF8-9A70DCAB7C1A@yandex-team.ru
Whole thread Raw
In response to Re: Supply restore_command to pg_rewind via CLI argument  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Supply restore_command to pg_rewind via CLI argument
List pgsql-hackers

> 14 сент. 2021 г., в 18:41, Daniel Gustafsson <daniel@yesql.se> написал(а):
>
>>> Besides this patch looks good and is ready for committer IMV.
>
> A variant of this patch was originally objected against by Michael, and as this
> version is marked Ready for Committer I would like to hear his opinions on
> whether the new evidence changes anything.

I skimmed the thread for reasoning. --target-restore-command was rejected on the following grounds

> Do we actually need --target-restore-command at all? It seems to me
> that we have all we need with --restore-target-wal, and that's not
> really instinctive to pass down a command via another command..

Currently we know that --restore-target-wal is not enough if postgresql.conf does not reside within PGDATA.

Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Increase value of OUTER_VAR
Next
From: Tom Lane
Date:
Subject: Re: Physical replication from x86_64 to ARM64