RE: Use fadvise in wal replay - Mailing list pgsql-hackers

From Jakub Wartak
Subject RE: Use fadvise in wal replay
Date
Msg-id AM8PR07MB82483DABE17210CBC3D872C9F6B39@AM8PR07MB8248.eurprd07.prod.outlook.com
Whole thread Raw
In response to Re: Use fadvise in wal replay  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: Use fadvise in wal replay  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
> > Maybe the important question is why would be readahead mechanism be
> disabled in the first place via /sys | blockdev ?
>
> Because database should know better than OS which data needs to be
> prefetched and which should not. Big OS readahead affects index scan
> performance.

OK fair point, however the patch here is adding 1 syscall per XLOG_BLCKSZ which is not cheap either. The code is
alreadyhot and there is example from the past where syscalls were limiting the performance [1]. Maybe it could be
prefetchingin larger batches (128kB? 1MB? 16MB?)  ? 

-J.

[1] - https://commitfest.postgresql.org/28/2606/





pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: Use fadvise in wal replay
Next
From: Peter Eisentraut
Date:
Subject: gcc -ftabstop option