RE: SIGSEGV, FPE fix in pg_controldata - Mailing list pgsql-hackers

From Ilyasov Ian
Subject RE: SIGSEGV, FPE fix in pg_controldata
Date
Msg-id AM0PR08MB36677978CDDD79F5469A7B98CDF42@AM0PR08MB3667.eurprd08.prod.outlook.com
Whole thread Raw
Responses Re: SIGSEGV, FPE fix in pg_controldata
List pgsql-hackers
Thank you for your answer, Alexander!
I like your patch and it looks similar to my first version of it before I came up to the possible segment size problem.

>Also, I don't think we should change
segment size to uint32 as it's already defined as int in awfully a lot
of places

I agree that changing segment size type is probably out of this thread and problem scope, but suppose it would be great
ifsomeone could tell me the story behind signed segment size as I see it is better unsigned. 


Kind regards,
Ian Ilyasov.

Junior Software Developer at Postgres Professional



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Commitfest app release on Feb 17 with many improvements
Next
From: Daniel Gustafsson
Date:
Subject: Re: add missing PQfinish() calls to vacuumdb