Re: multiset patch review - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: multiset patch review
Date
Msg-id AANLkTinw9=_Xdog2Q6-EECkBudXhM2fW+yTmbc=eSTbE@mail.gmail.com
Whole thread Raw
In response to Re: multiset patch review  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: multiset patch review  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
List pgsql-hackers
On Wed, Jan 12, 2011 at 23:29, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Two small nitpicks:
> + check_concatinatable(Oid element_type1, Oid element_type2)
> +         ereport(ERROR,
> +                 (errcode(ERRCODE_DATATYPE_MISMATCH),
> +                  errmsg("cannot concatenate incompatible arrays"),
> +                  errdetail("Arrays with element types %s and %s are not "
> +                            "compatible for concatenation.",
>
> I think the word is either "concatenable" or "concatenatable".  Also
> please don't break up the string in errdetail() even if it's longer than
> 80 chars.  (The function below this one has this too)

OK, I'll fix them,
but the broken up messages come from the existing code.

--
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add support for logging the current role
Next
From: Stephen Frost
Date:
Subject: Re: Add support for logging the current role