Re: pgAdmin III commit: Revert the previous change that introduced sysSetti - Mailing list pgadmin-hackers

From Peter Geoghegan
Subject Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date
Msg-id AANLkTinuk_CGUZNnQqcDa=H0fGd9-0urV4sxn93=U5fK@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin III commit: Revert the previous change that introduced sysSetti  (Dave Page <dpage@pgadmin.org>)
Responses Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
List pgadmin-hackers
On 17 February 2011 19:28, Dave Page <dpage@pgadmin.org> wrote:
> No objections to that, but it does need to handle interoperability
> with older versions too. IOW, it needs to read/write booleans as
> REG_SZ values of "true" or "false", not REG_DWORDS. There may be other
> gotchas too - that's the one I was hitting though.

What about the Read() overloads? They currently work by passing a
variable by reference (in the C sense, by pointer), to an overload of
read. ISTM that it would be preferable to have variants with different
names that return variables by value. What do you think?

By the way, this isn't that much trouble. I've already finished with
the write() overloads. We're mostly using the inline wrapper functions
in sysSettings.

--
Regards,
Peter Geoghegan

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Next
From: Peter Geoghegan
Date:
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti