Re: refactoring comment.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: refactoring comment.c
Date
Msg-id AANLkTinuHm-MgTc9QanGsRUL912kNC7L7Qbv9Up=9jpq@mail.gmail.com
Whole thread Raw
In response to Re: refactoring comment.c  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
Responses Re: refactoring comment.c
Re: refactoring comment.c
List pgsql-hackers
On Fri, Aug 27, 2010 at 5:57 PM, Kevin Grittner
<Kevin.Grittner@wicourts.gov> wrote:
> Robert Haas <robertmhaas@gmail.com> wrote:
>> I suppose this is unhappy because it things elog(ERROR) might
>> return?
>
> If I set these fields right in front of the elog(ERROR) the warnings
> go away for me.  (Hopefully this observation will make up, to some
> extent, for my earlier brain fart.)

I set them right after the ERROR so that those statements needn't
actually be executed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: Performance Farm Release
Next
From: "Kevin Grittner"
Date:
Subject: Re: refactoring comment.c