Re: We need to log aborted autovacuums - Mailing list pgsql-hackers

From Robert Haas
Subject Re: We need to log aborted autovacuums
Date
Msg-id AANLkTinqqHd-iOvxyPFBZkHDG7yb_4aZ846hDxgcrEeP@mail.gmail.com
Whole thread Raw
In response to Re: We need to log aborted autovacuums  (Cédric Villemain <cedric.villemain.debian@gmail.com>)
Responses Re: We need to log aborted autovacuums  (Cédric Villemain <cedric.villemain.debian@gmail.com>)
List pgsql-hackers
On Sat, Feb 5, 2011 at 3:20 PM, Cédric Villemain
<cedric.villemain.debian@gmail.com> wrote:
>> In the case where a table is skipped for this reason, we log a message
>> at log level LOG.  The version of the patch I posted does that
>> unconditionally, but my intention was to change it before commit so
>> that it only logs the message if log_autovacuum_min_duration is
>> something other than -1.
>
> yes looks better, I also note that someone suggest to not add a GUC for that.

I think a GUC just to control this one message is overkill.  Chances
are that if you're logging some or all of your autovacuum runs you'll
want to have this too, or at least it won't be a major problem to get
it anyway.  If for some reason you want ONLY this message, you can
effectively get that behavior too, but setting
log_autovacuum_min_duration to an enormous value.  So I can't really
imagine why you'd need a separate knob just for this one thing.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Cédric Villemain
Date:
Subject: Re: We need to log aborted autovacuums
Next
From: Cédric Villemain
Date:
Subject: Re: We need to log aborted autovacuums