Re: Stefan's bug (was: max_standby_delay considered harmful) - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Stefan's bug (was: max_standby_delay considered harmful)
Date
Msg-id AANLkTinbzhHYxgnryX1qYiyfL4i2NdezgPgLTCRb8S5W@mail.gmail.com
Whole thread Raw
In response to Re: Stefan's bug (was: max_standby_delay considered harmful)  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Stefan's bug (was: max_standby_delay considered harmful)
List pgsql-hackers
On Tue, May 18, 2010 at 3:09 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> (2)
>>> pg_ctl -ms stop emits the following warning whenever there is the
>>> backup_label file in $PGDATA.
>>>
>>>       WARNING: online backup mode is active
>>>       Shutdown will not complete until pg_stop_backup() is called.
>>>
>>> This warning doesn't fit in with the shutdown during recovery case.
>>> Since smart shutdown might be requested by other than pg_ctl, the
>>> warning should be emitted in server side rather than client, I think.
>>> How about moving the warning to the server side?
>
> Though I'm not sure if this should be fixed for 9.0, I attached the
> patch (move_bkp_cancel_warning_v1.patch).

This patch is worth applying for 9.0? If not, I'll add it into
the next CF for 9.1.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: ROLLBACK TO SAVEPOINT
Next
From: Stephen Frost
Date:
Subject: Re: Regression testing for psql