Re: SQL command to edit postgresql.conf, with comments - Mailing list pgsql-hackers

From Robert Haas
Subject Re: SQL command to edit postgresql.conf, with comments
Date
Msg-id AANLkTinb3yngKfpJDS54xb05gcC8SfSZ4_jHnfZseKC_@mail.gmail.com
Whole thread Raw
In response to Re: SQL command to edit postgresql.conf, with comments  (Josh Berkus <josh@agliodbs.com>)
Responses Re: SQL command to edit postgresql.conf, with comments
List pgsql-hackers
On Thu, Oct 14, 2010 at 12:40 PM, Josh Berkus <josh@agliodbs.com> wrote:
>
>> Sure. I just lose comments. I'll live with that.
>
> Actually, as part of this scheme, it would be nice if pg_settings had a
> "comment" column, which would be optionally set with SET PERMANENT.  Not
> required, but nice to have.
>
> If we had that, I suspect that a lot fewer people would want a hand-edited
> file.

I have to say that I'm woefully unimpressed by the idea of trying to
do anything with comments other than ignore them, even something this
simple.  There's no obvious way to know which comments go with which
settings.   You can make up a rule, such as "on the same line", but
it's not necessarily going to be what people want.  I think it's
better to sidestep the issue entirely.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: A small update for postgresql.conf.sample
Next
From: "Kevin Grittner"
Date:
Subject: Re: [JDBC] Support for JDBC setQueryTimeout, et al.