Re: Feature request: drop rules - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Feature request: drop rules
Date
Msg-id AANLkTinH-JycySuFK75dq9RZEmt8h0QqVA3tIFlD76t3@mail.gmail.com
Whole thread Raw
In response to Re: Feature request: drop rules  (Thom Brown <thombrown@gmail.com>)
Responses Re: Feature request: drop rules  (Thom Brown <thombrown@gmail.com>)
List pgadmin-hackers
On Wed, Jul 21, 2010 at 2:44 PM, Thom Brown <thombrown@gmail.com> wrote:
> On 21 July 2010 14:32, Dave Page <dpage@pgadmin.org> wrote:
>> On Wed, Jul 21, 2010 at 2:26 PM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>>
>>> Tried it. Still works for me. I'm on Linux, but I don't think it is the
>>> issue :)
>>
>> Actually, it might be. pgRule::CanDrop() is calling schema->CanDrop(),
>> however schema actually contains the table object. I think this is
>> because rules can exist under tables and views, so originally deriving
>> them from pgTableObject seemed wrong.
>>
>>
>> --
>
> I create a rule on a view, it comes up with the "Drop/Delete" and
> "Drop Cascaded" options.

I've pushed a commit that should fix this (as well as some icon
improvements that I previously forgot to push). You now get the option
to drop a rule from a table or view (though not if it's "the" rule
that implements the view), and no longer get the option to create
rules on system views.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

pgadmin-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: Feature request: drop rules
Next
From: Thom Brown
Date:
Subject: Re: Feature request: drop rules