Re: frmStatus: Assertion on linux and Segment Fault on Solaris - Mailing list pgadmin-hackers

From Dave Page
Subject Re: frmStatus: Assertion on linux and Segment Fault on Solaris
Date
Msg-id AANLkTinBmNgG002ZeuGsK0AnvkUXqrpbwNdD=+L-SsT7@mail.gmail.com
Whole thread Raw
In response to frmStatus: Assertion on linux and Segment Fault on Solaris  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Thanks - patch applied for trunk, 1.12 and 1.10 (which EDB are still using).

On Wed, Sep 1, 2010 at 9:42 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

I found that - while fetching and displaying the log, we are assuming that - all the columns will present at that point of time. (i.e. TimeStamp, Log Level, Log Entry).
But, it may present or not.
i.e. If we do not have log_prefix_line does not contain '%t', than TimeStamp column will not be present.
The following code suggests the same:
void frmStatus::AddLogPane()
{
    ...
    else    // Non-GPDB or non-CSV format log
    {
        if (logHasTimestamp)
            logList->AddColumn(_("Timestamp"), 100);

        if (logFormatKnown)
            logList->AddColumn(_("Level"), 35);

        logList->AddColumn(_("Log entry"), 800);
    }
   ...
}
So, we need to put the parsed logs in particular column based on these boolean values.
And, this was causing assert on linux and core dump on Solaris 10 sparc machine.

Please find patches for the REL-1_10_PATCHES and REL-1_12_PATCHES.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Prevent a crash in the log viewer on Solaris, by en
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix adminpack installation instructions, per Hennin