Re: pg_dump --split patch - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: pg_dump --split patch
Date
Msg-id AANLkTin7mNZQ252knDKX7F4W0TuMCNeQr8OQmGKjhSaf@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump --split patch  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
Responses Re: pg_dump --split patch
List pgsql-hackers
2010/12/29 Dimitri Fontaine <dimitri@2ndquadrant.fr>
Please have a look at getddl:

 https://github.com/dimitri/getddl


Nice! Looks like a nifty tool.
When I tried it, "./getddl.py -f -F /crypt/funcs -d glue", I got the error "No such file or directory: 'sql/schemas.sql'".

While the task of splitting objects into separate files could be solved by an external "wrapper tool" like yours around pg_dump,
I argue it makes more sense of putting the (minimal required) logics into pg_dump, due to a number of reasons, most importantly because it's simplier and less complex, thus less error prone.

My patch is only a few lines of code and doesn't add any logics to pg_dump, it merely reroutes the fwrite() system calls based on the toc entries.

Just the fact you and others had to create own tools to do the splitting shows the feature is important, which I think should be included in the normal pg_dump tool.

Happy new year!

Joel Jacobson
Glue Finance

pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: Re: new patch of MERGE (merge_204) & a question about duplicated ctid
Next
From: Mark Kirkwood
Date:
Subject: Re: Vacuum of newly activated 8.3.12 standby receives warnings page xxx is uninitialized --- fixing