On Thu, Nov 4, 2010 at 8:18 AM, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Thu, Nov 4, 2010 at 7:52 AM, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
>>> What about create_extension_extension instead? I'm not thinking of
>>> something better, bikeshedding is opened.
>>
>> That doesn't seem very clear... I'm always suspicious of names that
>> use the same word twice, and in this case I have no idea what this
>> variable would supposedly refer to.
>
> The ObjectAddress of the extension currently being installed by the
> CREATE EXTENSION command we're "in" (executing the script). The variable
> create_extension is already a boolean only set to true if in the code
> path.
How about calling it CurrentExtensionObjectAddress or something like
that? And maybe you don't need a boolean: if
(OidIsValid(CurrentExtensionObjectAddress.objid)) ...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
